Fixed: Improve article search in our application. #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3849 +/- ##
=========================================
Coverage 53.90% 53.90%
+ Complexity 1333 1331 -2
=========================================
Files 292 292
Lines 11119 11113 -6
Branches 1480 1477 -3
=========================================
- Hits 5994 5991 -3
+ Misses 4147 4138 -9
- Partials 978 984 +6 ☔ View full report in Codecov by Sentry. |
* Now we are using the same `ZimFileReader` object to search the articles. It reduces the search timing and avoids unnecessary allocation of objects in memory. * Refactored the `SearchViewModelTest` for this change. * After this change there is some unused code so we have removed that from our application.
…anguage` failed due to any reason. Because the language remains changed and other test cases will fail. Like it was failed in this PR on API level 30. * Also, improved our `DownloadTest`, because after changing the language of the application online content will change according to the new language so now we are using a generic approach for downloading the zim file.
MohitMaliFtechiz
force-pushed
the
Fix#3848
branch
from
3172fbc to
e914b25
Compare
|
So, badically, no user workflow changes? |
…licking on any article. * Added test cases for testing this scenario.
@kelson42 No, no workflow will change. With this change, we have improved the search functionality, now search works faster even in bigger zim files as now we are not creating unnecessary objects of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3848
Now we are using the same
ZimFileReaderobject to search the articles. It reduces the search timing and avoids unnecessary allocation of objects in memory.Refactored the
SearchViewModelTestfor this change.After this change, a few codes are become unused so we have removed that from our application.
Fixed the test cases that were failing if
testPauseAndResumeInOtherLanguagefailed due to any reason. Because the language remains changed and other test cases will fail. Like it was failed in this PR on API level 30(/~https://github.com/kiwix/kiwix-android/actions/runs/9113243814/job/25054265367).Also, improved our
DownloadTest, because after changing the language of the application online content will change according to the new language so now we are using a generic approach for downloading the zim file.Fixed the crash that playStore reported. It was due to the
rendermethod was called multiple times (7-14 times) when an item in the search list is clicked, which leads to unnecessary data loading and also causes a crash. The issue arises because the searchViewModel takes a moment to detach from the window, and during this time, this method is called multiple times due to the rendering process. To avoid unnecessary data loading and prevent crashes, we check if the search screen is visible to the user before proceeding. If the screen is not visible, we skip the data loading process. Below are crash logs reported by the playStore, and the same crash logs are generated by my device.