Enhance dynamic ports bundle and FreePortFinder #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Configure a FreePortFinder when creating the PortAssigner inside DynamicPortsBundle. * Remove LocalPortChecker from DynamicPortsConfiguration. * Add FreePortFinder to DynamicPortsConfiguration. * Remove LocalPortChecker from PortAssigner. * Make FreePortFinder support Jackson's polymorphic deserialization by adding JsonTypeInfo to FreePortFinder, adding JsonTypeName annotation to the three FreePortFinder impls, and adding an io.dropwizard.jackson.Discoverable in META-INF/services, plus org.kiwiproject.dropwizard.util.startup.FreePortFinder also in META-INF/services. * Lots of test refactoring and new tests. * Misc: fix Javadoc in StartupLockConfiguration Closes #545 Closes #546 Closes #547
dsingley
approved these changes
Oct 17, 2024
It can be null when the PortSecurity is NON_SECURE
AdminConfigurator, PortAssigner, and DynamicPortsConfiguration all transitively depend on TlsConfiguration (via kiwi's TlsContextConfiguration), so it makes some sense to change it from a test to a required dependency.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #545
Closes #546
Closes #547