Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Python 3 install instructions, fixes #710 #711

Conversation

AndreMiras
Copy link
Member

Refactors Python 2/3 install instructions.
Makes explicit difference between host and target Python.
Both host Python versions are supported seamlessly while target Python
requires different actions depending on the version.

tshirtman
tshirtman previously approved these changes Sep 2, 2018
@tshirtman
Copy link
Member

Looks good to me!

@tshirtman
Copy link
Member

Just a nit picking, it's better if the "-" lines under titles are the same length as the title itself, as it's what ReStructuredText specify, but i'm not sure it'll make a visible difference in output.

@AndreMiras
Copy link
Member Author

Thanks @tshirtman for reviewing. For the - I think I kinda get what you mean. You mean space+parenthesis e.g. ( should be converted to two dashes i.e. -- ? Is this what you meant?
I was also not sure at first so I did a live test and fixed it before doing the pull request.
You can try the end result on the README of my fork/branch here /~https://github.com/AndreMiras/buildozer/tree/feature/ticket710_update_readme_python3_instructions#installing-buildozer-with-target-python-3-crystax
It seems to work for me, give it a try playing with both link/anchor and let me know if you think it's OK.

@tshirtman
Copy link
Member

Sorry, i should have been clearer, i mean the dashes need to continue up to the end of the line, (so under the final ":").

Installing Buildozer with target Python 3 (CrystaX):
----------------------------------------------------

Refactors Python 2/3 install instructions.
Makes explicit difference between host and target Python.
Both host Python versions are supported seamlessly while target Python
requires different actions depending on the version.
@AndreMiras AndreMiras force-pushed the feature/ticket710_update_readme_python3_instructions branch from c7108bc to 6df7acd Compare September 2, 2018 22:16
@AndreMiras
Copy link
Member Author

Thank you it's super clear now, thanks for the heads-up! I've fixed it, also I definitely prefer markdown even more now 😄

@matham matham merged commit 79a7132 into kivy:master Sep 3, 2018
@AndreMiras AndreMiras deleted the feature/ticket710_update_readme_python3_instructions branch October 5, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants