Garden requirements #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires local copy of garden script.
…_requirements Conflicts: buildozer/__init__.py
| return | ||
|
|
||
| self._ensure_virtualenv() | ||
| self.cmd('pip-2.7 install -e git+git@github.com:Ian-Foote/kivy_garden.git#egg=garden', |
There was a problem hiding this comment.
Would it be possible to link over the kivy_garden of the garden community instead ? (i don't know if it exist, but if not, it should :))
There was a problem hiding this comment.
I split /~https://github.com/Ian-Foote/kivy_garden out of the main kivy repo - I was hoping my fork would get picked up officially as the one source of the garden install scripts.
|
Nice work, as always :) |
ghost
assigned Tweak garden_requirements.
| return | ||
|
|
||
| self._ensure_virtualenv() | ||
| self.cmd('pip-2.7 install -e git+/~https://github.com/kivy-garden/garden.git@0.1.1#egg=Kivy-Garden-0.1.1', |
There was a problem hiding this comment.
I've updated this to match the work done to fix kivy/kivy#1580.
|
I'd find this useful. |
|
@Ian-Foote thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this pull request for some code review.
This adds support for kivy garden modules to buildozer, avoiding the need to clutter the App's source directory.
There is some cleanup still possible - e.g. simplify the pip install of the kivy_garden scripts - but the code is functional and easy to use at this point. I have only tested on linux.
Fixes #39.