-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation.rst #1500
Update installation.rst #1500
Conversation
Update jdk and Ubuntu versions. Update WSL usage instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Left 2 minor suggestions, but absolutely LGTM. Thank you! ❤️
I'm wondering if it's better to also include a section that advises using a full-featured VM, instead of WSL*, but that's another topic. 🧐
Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>
Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>
Thank you for the improvements. One question, is Cython still a user install requirement? I ask because somewhere I noticed Buildozer using Cython 3 - which means it downloads its own version. Can Cython be removed here? Yes, any VE documentation should be platform independent. (IMO for somebody who installed WSL just to run Buildozer, a VE is complexity without utility - which is why I removed it). |
If Cython doesn't get installed by the user buildozer/buildozer/targets/android.py Line 297 in 1a7191e
And nope, python-for-android doesn't install (or give instructions to buildozer via install reqs ) Cython.
(Previously [~3/4 years ago ] we were using the system-wide cython install, so that's why) Yeah, we may need to do some renovations 🏡 , but now is still a user install requirement 😄.
Agree! |
Thanks again! |
* Add support --res_xml option in p4a * res_xml paths are relative to buildozer.spec * Changes for NDK23 (kivy#1427) The arch no longer used in url for NDK23+ * Our self-hosted Apple Silicon runner now has been migrated to actions/runner v2.292.0 which now supports arm64 natively (kivy#1438) * use p4a --add-source instead of manual copy (kivy#1450) Currently, android.add_src does not work anymore. Using --add-source from p4a make it work again. * fix aar build (kivy#1444) * fix aar build * update default.spec to include 'debug_artifact' * Updates default buildozer.spec NDK from 19b to 23b (kivy#1462) * Update CHANGELOG and prepare release 1.4.0 (kivy#1463) * Bump version to 1.4.1.dev0 (kivy#1464) * p4a prerequisites install should be done in non-interactive mode during CI builds. (kivy#1465) * Avoid the usage of `shell=True` in Popen, which could lead to potential security risks. (kivy#1435) * Removes (where possible) the usage of shell=True in Popen * Fixes (needs check on runtime) adb + add a solution for p4a.extra_args * Change the logic to auto accept the SDK licenses, to avoid the shell=True usage * Removes six dependency in tests (kivy#1475) * Fixes some E275 - assert is a keyword. (kivy#1495) * Fix presplash color (kivy#1497) Buildozer wont build if a presplash color is set, this should fix it as descrived in kivy#1487 * Show output during aab support check, as p4a may require the user input (kivy#1494) * Update installation.rst (kivy#1500) * Update installation.rst Update jdk and Ubuntu versions. Update WSL usage instructions. * Update installation.rst * Update docs/source/installation.rst Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com> * Update docs/source/installation.rst Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com> Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com> Co-authored-by: Eero af Heurlin <eero.afheurlin@iki.fi> Co-authored-by: HyTurtle <81598434+HyTurtle@users.noreply.github.com> Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com> Co-authored-by: Mathieu Virbel <mat@meltingrocks.com> Co-authored-by: Mikhail Zakharov <mzakharo@users.noreply.github.com> Co-authored-by: Akshay Arora <akshayaurora@gmail.com> Co-authored-by: Apacelus <46828271+apacelus@users.noreply.github.com> Co-authored-by: RobertF <34464649+RobertFlatt@users.noreply.github.com>
Update jdk and Ubuntu versions.
Update WSL usage instructions.