Starts unit testing buildozer/targets/android.py #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a best effort approach trying to increase the coverage of that module. Therefore some tests are not completely isolating all dependencies via `mock.patch`-ing. Subsequent pull request could cover more methods and focus on edge case. This increases the overall coverage from 20% to 25% and `buildozer/targets/android.py` coverage from 15% to `24%`.
AndreMiras
force-pushed
the
feature/test_android_module
branch
from
ca260ff to
0c4116c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a best effort approach trying to increase the coverage of that module. Therefore some tests are not completely isolating all dependencies via
mock.patch-ing.Subsequent pull request could cover more methods and focus on edge case.
This increases the overall coverage from 20% to 25% and
buildozer/targets/android.pycoverage from 15% to24%.