Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly upgrading a dependency that doesn't exist doesn't error #680

Closed
epage opened this issue Mar 28, 2022 · 1 comment · Fixed by #726
Closed

Explicitly upgrading a dependency that doesn't exist doesn't error #680

epage opened this issue Mar 28, 2022 · 1 comment · Fixed by #726
Labels
cargo-upgrade

Comments

@epage
Copy link
Collaborator

epage commented Mar 28, 2022

This is split out of #678
@epage
Copy link
Collaborator Author

epage commented Mar 28, 2022

Since we support running this across a workspace, should we error if not all crates have the dependency, if not all the specified crates have the dependency, or should we instead warn since someone might run this blindly.

This was referenced Mar 28, 2022
Closed
Open
epage added a commit to epage/cargo-edit that referenced this issue Jul 13, 2022
@epage
fix(upgrade): Report errors for invalid dependencies
f2c45fb 
Fixes killercup#680
@epage epage mentioned this issue Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cargo-upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(upgrade): Report errors for invalid dependencies epage/cargo-edit
1 participant
@epage