Fix Khoj Obsidian plugin on Obsidian Mobile #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugins using NodeJS libraries like `node-fetch' don't work on Obsidian mobile
sabaimran
approved these changes
Feb 6, 2024
- Obsidian mobile uses capacitor js. Requests from it have origin as http://localhost on Android and capacitor://localhost on iOS - Allow those Obsidian mobile origins in CORS middleware of server
Put logic into single reused function
…ered This reduces laggy feeling due to latency of loading chat history from server
debanjum
force-pushed
the
fix-khoj-on-obsidian-mobile
branch
from
00355ea to
fd238ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed node-fetch dependency to work on mobile. Fix CORS issue for Khoj (streaming) chat on Obsidian mobile. Verified Khoj plugin, search, chat work on Obsidian mobile.
Major
fetch' notnode-fetch' in obsidian pluginMinor