chore(windows): ensure dependencies for keyman32 exclude core:wasm #13379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
requested review from
rc-swag,
ermshiperete and
srl295
as code owners
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
removed
the
user-test-missing
mcdurdin
commented
Feb 28, 2025
| @@ -92,16 +93,20 @@ fi | |||
| # generates a 'fat' library from them. | |||
| builder_describe_internal_dependency \ | |||
There was a problem hiding this comment.
Comment on lines
+149
to
+150
| builder_run_action configure:mac mkdir -p "$KEYMAN_ROOT/core/build/mac/$BUILDER_CONFIGURATION" | ||
| builder_run_action configure:win mkdir -p "$KEYMAN_ROOT/core/build/win/$BUILDER_CONFIGURATION" |
There was a problem hiding this comment.
Also shortened to use builder_run_action instead of builder_start_action + builder_finish_action
darcywong00
reviewed
Mar 1, 2025
| "$KEYMAN_ROOT/core/build/mac-arm64/$BUILDER_CONFIGURATION/src/libkeymancore.a" \ | ||
| -output "$KEYMAN_ROOT/core/build/mac/$BUILDER_CONFIGURATION/libkeymancore.a" | ||
|
|
||
| builder_run_action build:win touch "$KEYMAN_ROOT/core/build/win/$BUILDER_CONFIGURATION/BUILT" |
There was a problem hiding this comment.
Does /BUILT ever get cleaned?
There was a problem hiding this comment.
Good question -- not at this point. Might be worth a future PR to do clean for both :mac and :win.
mcdurdin
deleted the
chore/windows/13374-ensure-keyman32-deps-exclude-wasm-core
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
:winmeta-target to the /core/build.sh project. This:wintarget triggers both:x86and:x64targets, and allows us to specify@/core:winin the windows/keyman32/build.sh project, in order to build only those two targets, and not:wasmtarget as well (as we don't need WASM Core for Keyman for Windows).This closely mirrors the pattern we used for
:macin /core/build.sh. We could consider using:archinstead of:winand:macbut that needs more careful consideration, as:archimplies only the current architecture of the building machine.This change also sets us up well for when we start doing arm32 and arm64 builds for Windows on ARM in the near future.
Fixes: #13374
@keymanapp-test-bot skip