-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[khmer_angkor] version 2.0 #3228
Conversation
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
FYI @MakaraSok and @mcdurdin. |
@MakaraSok will you be checking this? |
@MakaraSok should I check this or are you planning to review this? |
Hi Team,
I do not have any bandwidth for this. Please go ahead and take necessary
action.
If anything, I will submit a bug report.
Thanks,
Makara
នៅថ្ងៃទី សុក្រ 7 កុម្ភៈ 2025 នៅម៉ោង 10:19 PM Lorna Evans <
***@***.***> បានសរសេរ៖
… @MakaraSok </~https://github.com/MakaraSok> should I check this or are you
planning to review this?
—
Reply to this email directly, view it on GitHub
<#3228 (comment)>,
or unsubscribe
</~https://github.com/notifications/unsubscribe-auth/AGYE27EKGH6X4QPMQECCHXT2OTFGNAVCNFSM6AAAAABS5CJ7LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBTGIZDMNBSHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Remove copyright years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We'll probably want to update the keyboard to use Busra, but let's do that separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little late, but just noticed this issue. I haven't actually tested the keyboard yet but will install on my phone soon
<File> | ||
<Name>welcome\KAK_Documentation_KH.pdf</Name> | ||
<Description>File KAK_Documentation_KH.pdf</Description> | ||
<CopyLocation>0</CopyLocation> | ||
<FileType>.pdf</FileType> | ||
</File> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why this file was removed from the package? (Also I see three copies of the PDFs -- in extras, help, and welcome. We probably don't need 3 copies! (The package can use the ones from welcome/, as it already is)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally missed that. I removed the old doc and forgot to add the new one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why the pdfs are in 3 different places. I followed the previous files structure. I will remove the pdfs in extras and help in a new PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the help folder, there's a khmer_angkor.php
file. Does this file link to the pdfs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you can see the help file online: https://help.keyman.com/keyboard/khmer_angkor/2.0/khmer_angkor It links to the pdfs. The pdfs do need to be in the help
folder if you want the link to stay there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@LornaSIL, Should I use Khmer Busra to replace Mondulkiri (that is used for touch layout)? |
I think Khmer Busra is already used for the DisplayFont and KbdKhmr for the OSKFont, in the .kps?
|
Yes, you can change the Mondulkiri fonts out and switch to Busra-Regular. I would include all the fonts in the keyboard package. |
Busra fonts (six *.ttf files) recently added to the shared fonts: |
I didn't realize that this update of the keyboard completely changed the touch layout. This is difficult for people who are already familiar with the keyboard. Is there documentation and transition information for existing users? |
Yes, it was included in the pdf both Khmer and English. |
Can we do an update that includes that information in welcome.htm as well? Many users will never open the PDF |
No description provided.