Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[khmer_angkor] version 2.0 #3228

Merged
merged 8 commits into from
Feb 10, 2025
Merged

[khmer_angkor] version 2.0 #3228

merged 8 commits into from
Feb 10, 2025

Conversation

Nnyny
Copy link
Contributor

@Nnyny Nnyny commented Dec 3, 2024

No description provided.

@Nnyny Nnyny marked this pull request as draft December 3, 2024 06:58
@keyman-server
Copy link
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@Nnyny Nnyny marked this pull request as ready for review December 9, 2024 06:09
@Nnyny
Copy link
Contributor Author

Nnyny commented Dec 9, 2024

FYI @MakaraSok and @mcdurdin.

@mcdurdin mcdurdin requested a review from MakaraSok December 9, 2024 06:25
@LornaSIL
Copy link
Contributor

LornaSIL commented Jan 6, 2025

@MakaraSok will you be checking this?

@LornaSIL
Copy link
Contributor

LornaSIL commented Feb 7, 2025

@MakaraSok should I check this or are you planning to review this?

@MakaraSok
Copy link
Collaborator

MakaraSok commented Feb 10, 2025 via email

@LornaSIL LornaSIL requested review from LornaSIL and removed request for MakaraSok February 10, 2025 14:54
Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We'll probably want to update the keyboard to use Busra, but let's do that separately.

@LornaSIL LornaSIL merged commit 599ff6d into keymanapp:master Feb 10, 2025
2 checks passed
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little late, but just noticed this issue. I haven't actually tested the keyboard yet but will install on my phone soon

Comment on lines -109 to -114
<File>
<Name>welcome\KAK_Documentation_KH.pdf</Name>
<Description>File KAK_Documentation_KH.pdf</Description>
<CopyLocation>0</CopyLocation>
<FileType>.pdf</FileType>
</File>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why this file was removed from the package? (Also I see three copies of the PDFs -- in extras, help, and welcome. We probably don't need 3 copies! (The package can use the ones from welcome/, as it already is)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally missed that. I removed the old doc and forgot to add the new one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the pdfs are in 3 different places. I followed the previous files structure. I will remove the pdfs in extras and help in a new PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the help folder, there's a khmer_angkor.php file. Does this file link to the pdfs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can see the help file online: https://help.keyman.com/keyboard/khmer_angkor/2.0/khmer_angkor It links to the pdfs. The pdfs do need to be in the help folder if you want the link to stay there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Nnyny
Copy link
Contributor Author

Nnyny commented Feb 11, 2025

@LornaSIL, Should I use Khmer Busra to replace Mondulkiri (that is used for touch layout)?

@Nnyny Nnyny deleted the khmer_angkor branch February 11, 2025 06:05
@mcdurdin
Copy link
Member

@LornaSIL, Should I use Khmer Busra to replace Mondulkiri (that is used for touch layout)?

I think Khmer Busra is already used for the DisplayFont and KbdKhmr for the OSKFont, in the .kps?

      <OSKFont>..\..\..\shared\fonts\kbd\kbdkhmr\KbdKhmr.ttf</OSKFont>
      <DisplayFont>..\..\..\shared\fonts\khmer\mondulkiri\Mondulkiri-R.ttf</DisplayFont>

@LornaSIL
Copy link
Contributor

Yes, you can change the Mondulkiri fonts out and switch to Busra-Regular. I would include all the fonts in the keyboard package.

@DavidLRowe
Copy link
Contributor

Busra fonts (six *.ttf files) recently added to the shared fonts: release/shared/fonts/sil/busra/

@mcdurdin
Copy link
Member

I didn't realize that this update of the keyboard completely changed the touch layout. This is difficult for people who are already familiar with the keyboard. Is there documentation and transition information for existing users?

@Nnyny
Copy link
Contributor Author

Nnyny commented Feb 12, 2025

Yes, it was included in the pdf both Khmer and English.

@mcdurdin
Copy link
Member

Can we do an update that includes that information in welcome.htm as well? Many users will never open the PDF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants