Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Members pagination #527

Merged
merged 3 commits into from
May 24, 2021
Merged

Members pagination #527

merged 3 commits into from
May 24, 2021

Conversation

sl-benoitoyez
Copy link
Contributor

@sl-benoitoyez sl-benoitoyez commented May 7, 2021 •
edited
Loading

Closes #526

I set arbitrarily the pagination value to 50, I can change it if you think another value would be better.

The changes are only on the backstage side, no changes to the resource signature.

mrparkers
mrparkers approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review. This looks good, and the existing test for this resource with 100 members seems to pass.

Thanks for the PR!

@mrparkers mrparkers merged commit 458fa5c into keycloak:master May 24, 2021
@sl-benoitoyez sl-benoitoyez deleted the members_pagination branch May 25, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement pagination for group memberships
2 participants
@sl-benoitoyez @mrparkers