Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clients] - Add attributes #387

Closed
slavko-vega opened this issue Sep 17, 2020 · 3 comments
Closed

[Clients] - Add attributes #387

slavko-vega opened this issue Sep 17, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@slavko-vega
Copy link

slavko-vega commented Sep 17, 2020 •
edited
Loading

Hi @mrparkers,

we noticed that Clients are missing attributes, which are needed by our project. Currently the Attributes, as they are implemented, are limited to a subset of Client's properties which are used by Keycloak. What we actually need is possibility to add our custom attributes as it's possible for other resources.

Haven't seen that the issue is reported yet. I'd like to contribute on its implementation, if you consider this as an issue.

Do you agree with that?
@mrparkers
Copy link
Contributor

Hey @slavko-vega, that sounds great! I'd definitely accept a PR that adds an attributes argument to the keycloak_openid_client and/or keycloak_saml_client resources.

@mrparkers mrparkers added the enhancement New feature or request label Sep 21, 2020
@slavko-vega
Copy link
Author

Hey @mrparkers I'm glad to contribute on this issue and PR is prepared.

@slavko-vega slavko-vega mentioned this issue Sep 25, 2020
Closed
olivierboudet pushed a commit to olivierboudet/terraform-provider-keycloak that referenced this issue Aug 19, 2021
add extra_config for openid clients to handle custom attributes (keyc…
ee6f0eb 
…loak#387)
olivierboudet pushed a commit to olivierboudet/terraform-provider-keycloak that referenced this issue Aug 19, 2021
add extra_config for openid clients to handle custom attributes (keyc…
4e326f6 
…loak#387)
olivierboudet pushed a commit to olivierboudet/terraform-provider-keycloak that referenced this issue Aug 31, 2021
add extra_config for openid clients to handle custom attributes (keyc…
b84ef5f 
…loak#387)
olivierboudet pushed a commit to olivierboudet/terraform-provider-keycloak that referenced this issue Aug 31, 2021
@olivierboudet
add extra_config for openid clients to handle custom attributes (keyc…
40c3d18 
…loak#387)
olivierboudet pushed a commit to olivierboudet/terraform-provider-keycloak that referenced this issue Aug 31, 2021
@olivierboudet
add extra_config for openid clients to handle custom attributes (keyc…
078bac5 
…loak#387)
olivierboudet pushed a commit to olivierboudet/terraform-provider-keycloak that referenced this issue Aug 31, 2021
@olivierboudet
add extra_config for openid clients to handle custom attributes (keyc…
1311e66 
…loak#387)
@slavko-vega slavko-vega mentioned this issue Sep 11, 2021
Closed
@mrparkers
Copy link
Contributor

Closed via #589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrparkers @slavko-vega