Updating instructions for newer exotic-ld versions #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves #540 I've set a lower limit on the exotic-ld version to 3.1.2 which is their latest version (contains the updated post commissioning sensitivity files for JWST), and I've updated the documentation to make sure folks know how to download those reference files and know that the reference files change with different ExoTiC-LD reference files.
taylorbell57
added
documentation
kevin218
previously approved these changes
Feb 9, 2024
|
Just realized this is failing because the ExoTiC-LD code (on pip and GitHub) only has version 3.0.0 while the reference files are on 3.1.2. I've sent David and Hannah an email to make sure we're supposed to use those two together; Hannah is out of the office for a while, so hopefully David responds fairly soon. Either way, I'll have to tweak some of the files and wording to make that clearer in these instructions. |
kevin218
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #540
I've set a lower limit on the exotic-ld version to 3.1.2 which is their latest version (contains the updated post commissioning sensitivity files for JWST), and I've updated the documentation to make sure folks know how to download those reference files and know that the reference files change with different ExoTiC-LD reference files.