Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Permission denied" error in the Kentik dashboards #28

Merged
merged 2 commits into from
Dec 26, 2019

Conversation

corpglory-dev
Copy link

Currently only Admins can see the Kentik dashboards. Viewers and Editors get "Permission denied" error when trying to open a Kentik dashboard.

The error happens because the dashboards are trying to read the Kentik datasource settings from Grafana but it can be done only by Admins.

This PR makes it able to open the Kentik dashboards by Viewers and Editors, not only by Admins.

How to make the plugin work after the update

Changes

  • Plugin Config page: new "invisible" url field which can be used by plugin.json. It's set according to the "Region" type when the "Update" button is clicked
  • plugin.json: replace region-specific proxy routes (default/api/v5, eu/api/v5, custom/api/v5) with a generic api/v5/* route. The new route uses the url field from the plugin config
  • datasource/kentik_api.ts: use the new route instead of region-specific ones
  • remove "Region" usage from all Kentik panels and components
  • remove datasource/region_helper.ts as it's not used anymore
  • fix tests

@jkowall jkowall merged commit 584ebb8 into master Dec 26, 2019
@corpglory-dev corpglory-dev deleted the viewer-permission-denied branch December 26, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants