Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui,be): minor bugs on Incidents after facets #3072

Merged
merged 8 commits into from
Jan 21, 2025
Merged

fix(ui,be): minor bugs on Incidents after facets #3072

merged 8 commits into from
Jan 21, 2025

Conversation

skynetigor
Copy link
Contributor

Closes #3069

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 3:12pm

@skynetigor skynetigor marked this pull request as ready for review January 21, 2025 12:47
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Bug Something isn't working UI User interface related issues labels Jan 21, 2025
talboren
talboren previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 21, 2025
talboren
talboren approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skynetigor skynetigor merged commit e198e74 into main Jan 21, 2025
12 checks passed
@skynetigor skynetigor deleted the 3069_fix_bugs branch January 21, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Some issues with facets in Incidents page
2 participants
@skynetigor @talboren