fix: Text writing direction to handle RTL languages (#114) #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request addresses a text alignment issue in right-to-left (RTL) user interfaces within text view, specifically related to text being aligned at the trailing edge of text views. The problem is also detailed in Issue #114.
Solution
To resolve this, I have implemented a fix by setting the
baseWritingDirection
in the paragraph styles to override the default behavior.Considerations
It's important to note that this fix might alter the appearance of logs completely written in RTL languages. However, this change is justified, considering the limitations in Xcode's editor regarding RTL language support, especially when RTL strings are combined with String Interpolation. As a result, string literals, particularly for logging purposes like network logs, are predominantly written in English.
Furthermore, considering network logging specifically, many standards and protocols are inherently in English, including standard headers and their values. This consideration supports the decision to enforce a left-to-right base writing direction for improved readability and consistency in such contexts.