Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret decode #242

Merged
merged 13 commits into from
Aug 17, 2022
Merged

Secret decode #242

merged 13 commits into from
Aug 17, 2022

Conversation

aalsup
Copy link

@aalsup aalsup commented Aug 16, 2022

This PR contains a new keybinding for char('x'). When viewing secrets, this new handler logic allows the user to see the base64-decoded secret contents.

@deepu105
Copy link
Contributor

Awesiome! Thanks. Could you add one or two tests for the decoding part please

@aalsup
Copy link
Author

aalsup commented Aug 16, 2022

I've added a test -- test_decode_secret. I've also done a little cleanup to make clippy happy. Let me know if you'd like me to change the way its implemented. I wasn't sure where exactly to put the handler for decoding the secret, so I put the logic within the handle_describe_or_yaml_action() function - possibly not the ideal place, but it does work.

Copy link
Contributor

@deepu105 deepu105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👏

@deepu105 deepu105 merged commit 23df3c9 into kdash-rs:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants