Adding support for storageclass #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you 🙏. I'm on vacation now. I'll check and merge in 2 weeks when I'm back |
shinusuresh
force-pushed
the
feat/storageclass
branch
from
05f1aab to
943a980
Compare
deepu105
approved these changes
Jul 26, 2022
| pub(crate) mod svcs; | ||
| mod utils; | ||
|
|
||
| use crate::app::storageclass::KubeStorageClass; |
There was a problem hiding this comment.
move it to existing import grouping below in line 40. If you are using VSCode it should do that when you format
src/app/mod.rs
Outdated
| @@ -123,6 +126,7 @@ pub struct Data { | |||
| pub logs: LogsState, | |||
| pub describe_out: ScrollableTxt, | |||
| pub metrics: StatefulTable<(Vec<String>, Option<QtyByQualifier>)>, | |||
| pub storageclasses: StatefulTable<KubeStorageClass>, | |||
There was a problem hiding this comment.
move to line 125 for consistency plz
src/app/mod.rs
Outdated
| @@ -195,6 +199,7 @@ impl Default for Data { | |||
| logs: LogsState::new(String::default()), | |||
| describe_out: ScrollableTxt::new(), | |||
| metrics: StatefulTable::new(), | |||
| storageclasses: StatefulTable::new(), | |||
src/handlers/mod.rs
Outdated
| @@ -479,6 +494,7 @@ async fn handle_block_scroll(app: &mut App, up: bool, is_mouse: bool, page: bool | |||
| ActiveBlock::RplCtrl => app.data.rpl_ctrls.handle_scroll(up, page), | |||
| ActiveBlock::Contexts => app.data.contexts.handle_scroll(up, page), | |||
| ActiveBlock::Utilization => app.data.metrics.handle_scroll(up, page), | |||
| ActiveBlock::StorageClasses => app.data.storageclasses.handle_scroll(up, page), | |||
src/network/kube_api.rs
Outdated
| @@ -332,4 +333,13 @@ impl<'a> Network<'a> { | |||
| None => Api::all(self.client.clone()), | |||
| } | |||
| } | |||
|
|
|||
| pub async fn get_storage_classes(&self) { | |||
There was a problem hiding this comment.
move to line 301 to seperate pub and private functions visually
src/ui/resource_tabs.rs
Outdated
| "Name", | ||
| "Provisioner", | ||
| "Reclaim Policy", | ||
| "Volume binding mode", |
There was a problem hiding this comment.
Suggested change
| "Volume binding mode", | |
| "Volume Binding Mode", |
src/ui/resource_tabs.rs
Outdated
| "Provisioner", | ||
| "Reclaim Policy", | ||
| "Volume binding mode", | ||
| "Allow volume expansion", |
There was a problem hiding this comment.
Suggested change
| "Allow volume expansion", | |
| "Allow Volume Expansion", |
|
@deepu105 - Review changes are pushed. Can you take a look when you get time, please? |
|
Thank you @deepu105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #50