Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Adopt CNCF Code of Conduct #3027

Merged
merged 1 commit into from
Oct 13, 2023
Merged

📖 Adopt CNCF Code of Conduct #3027

merged 1 commit into from
Oct 13, 2023

Conversation

embik
Copy link
Member

@embik embik commented Oct 13, 2023

Summary

We are joining the CNCF as Sandbox project, and as such are subject to the CNCF CoC. I would suggest this PR as a way to adopting it and fulfil the onboarding requirement.

Related issue(s)

Fixes #

Release Notes

NONE

@embik
Adopt CNCF Code of Conduct
dc9142e 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 13, 2023
@embik
Copy link
Member Author

embik commented Oct 13, 2023

/cc @clubanderson @sttts @scheeles @mjudeikis @xrstf

I would like to get feedback from a major of maintainers before we go ahead with this change.

@embik
Copy link
Member Author

embik commented Oct 13, 2023

/hold

until we have sufficient reviews.

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@xrstf
Copy link
Contributor

xrstf commented Oct 13, 2023

/approve

I approve of the idea, but cannot really judge the wording, as I don't know why we diverged from the CoC originally.

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@mjudeikis
Copy link
Contributor

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a659aaed84df23e3af7ff094cea085a0d4370c1

@embik
Copy link
Member Author

embik commented Oct 13, 2023

/approve

I approve of the idea, but cannot really judge the wording, as I don't know why we diverged from the CoC originally.

I do not believe we have diverged from the CNCF CoC at some point, but the CNCF CoC is a modernized version.

@sttts
Copy link
Member

sttts commented Oct 13, 2023

/lgtm

@mjudeikis
Copy link
Contributor

/retest

@mjudeikis mjudeikis removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@kcp-ci-bot kcp-ci-bot merged commit 1404246 into kcp-dev:main Oct 13, 2023
@embik embik deleted the cncf-coc branch October 13, 2023 18:29
@embik embik mentioned this pull request Oct 14, 2023
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clubanderson clubanderson Awaiting requested review from clubanderson

@mjudeikis mjudeikis Awaiting requested review from mjudeikis

@scheeles scheeles Awaiting requested review from scheeles

@sttts sttts Awaiting requested review from sttts

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@sttts sttts

@mjudeikis mjudeikis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@embik @xrstf @kcp-ci-bot @mjudeikis @sttts