Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Document data types that are replicated #2925

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Mar 27, 2023

Summary

While we have this code structure in some controllers, it's useful to document for contributors.

Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@nrb nrb requested a review from ncdc March 27, 2023 18:13
@openshift-ci openshift-ci bot requested a review from jmprusi March 27, 2023 18:13
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but can we also document internal.kcp.io/replicate either in this PR or a follow-up? The GoDoc seems incorrect.

@nrb
Copy link
Contributor Author

nrb commented Mar 27, 2023

That's a great question - it appears to only be relevant for LogicalClusters, ClusterRoles, and ClusterRoleBindings

@davidfestal is the internal.kcp.io/replicate annotation only used for filtering these three types, or is its use more broad?

@davidfestal
Copy link
Member

I think that for now it's mostly for these 3
cc @sttts

@nrb
Copy link
Contributor Author

nrb commented Mar 29, 2023

IMO we can add the annotation later. Sounds like the team's not super clear on it either.

@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023
@openshift-merge-robot openshift-merge-robot merged commit abdae2b into kcp-dev:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants