🌱 syncer vw: add API definition logging #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
changed the title
ncdc
changed the title
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
Fix bug in IndexSyncTargetsByExports where it was trying to fall back to the SyncTarget's path if a reference to an APIExport had an empty path, but instead of checking the path, it was accidentally checking the name. Also clean up index-related code. Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
ncdc
force-pushed
the
deflake-upsyncer-pv
branch
from
4b01d1b to
993f42b
Compare
ncdc
commented
Feb 10, 2023
| return []string{client.ToClusterAwareKey(clusterName.Path(), reconcilerapiexport.TemporaryComputeServiceExportName)}, nil | ||
| } | ||
|
|
||
| keys := make([]string, 0, len(synctarget.Spec.SupportedAPIExports)) | ||
| for _, export := range synctarget.Spec.SupportedAPIExports { | ||
| if len(export.Export) == 0 { |
There was a problem hiding this comment.
FYI @davidfestal @sttts I'm pretty sure this is a bug, right?
There was a problem hiding this comment.
There is a chance this is the root cause of #2762
There was a problem hiding this comment.
I agree it seems a bug that might be related to the mentioned issue.
davidfestal
approved these changes
Feb 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
kcp-ci-bot
added
the
size/M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to figure out kcp-dev/contrib-tmc#53