🐛 Fix API binding privilege escalation #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
s-urbaniak
changed the title
s-urbaniak
force-pushed
the
fix-wrong-bind
branch
from
d593e37 to
05645c0
Compare
openshift-merge-robot
added
the
needs-rebase
s-urbaniak
force-pushed
the
fix-wrong-bind
branch
from
05645c0 to
c529b4c
Compare
openshift-merge-robot
removed
the
needs-rebase
s-urbaniak
force-pushed
the
fix-wrong-bind
branch
5 times, most recently
from
2ae210f to
434ecae
Compare
s-urbaniak
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
s-urbaniak
force-pushed
the
fix-wrong-bind
branch
4 times, most recently
from
0fd200c to
01a4b02
Compare
|
/test e2e-sharded |
2 similar comments
|
/test e2e-sharded |
|
/test e2e-sharded |
Currently, privilege escalation can be provoked when creating APIBindings for exported resources. This fixes it by impersonating virtual API export requests with a service account that is bound to the requested workspace.
s-urbaniak
force-pushed
the
fix-wrong-bind
branch
from
01a4b02 to
7035800
Compare
ncdc
approved these changes
Feb 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, privilege escalation can be provoked when creating APIBindings
for exported resources.
This fixes it by impersonating virtual API export requests with a
service account that is bound to the requested workspace.
Related issue(s)
Fixes #2239