🐛 reconciler/cache: remove reflection and fix replicate+NotFound logic #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
force-pushed
the
sttts-cache-nil
branch
from
2dbd5ae to
a04c4ff
Compare
p0lyn0mial
reviewed
Jan 11, 2023
p0lyn0mial
reviewed
Jan 11, 2023
|
/lgtm |
vincepri
reviewed
Jan 11, 2023
|
/approve |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
sttts
force-pushed
the
sttts-cache-nil
branch
from
a04c4ff to
6d09ce2
Compare
|
/lgtm |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold Hotlooping. |
openshift-ci
bot
added
the
do-not-merge/hold
sttts
force-pushed
the
sttts-cache-nil
branch
from
6d09ce2 to
f7fa645
Compare
|
#2601 |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
ncdc
approved these changes
Jan 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe fixing the npe flake.
Maybe fixing the npe flake.
Maybe fixing the npe flake.
Maybe fixing the npe flake.
Maybe fixing the npe flake.