🐛 e2e: PrivateKcpServer enable audit-policy

[hardys]

Summary

Otherwise we end up with zero-length audit logs in CI...

For example see this - AFAICS all tests using PrivateKcpServer have this problem because we only set the audit-policy flag in the SharedKcpServer fixture

[hardys]

/assign @s-urbaniak we discussed this yesterday, PTAL :)

[hardys]

/hold

This requires further changes since some tests like TestAuditLogs set the flag explicitly

[stevekuznetsov]

LGTM once you update the other tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hardys]

LGTM once you update the other tests.

Thanks @stevekuznetsov - I decided to just default the flag so we only set when not explicitly passed by the test - we can see that working e.g here

We also need to de-duplicate the --audit-log-path in TestAuditLogs but I'll do that as a follow up given it's currently working, and will depend on the ScratchDirs changes we've been discussing in #2407

[hardys]

/hold cancel

[s-urbaniak]

/lgtm