Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cluster name annotation #1673

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Aug 3, 2022

Summary

Stop using ZZZ_DeprecatedClusterName and switch to cluster name via an annotation.

Depends on:

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ncdc
Copy link
Member Author

ncdc commented Aug 3, 2022

/test all

@openshift-ci openshift-ci bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Aug 3, 2022
@ncdc
Copy link
Member Author

ncdc commented Aug 3, 2022

/test all

1 similar comment
@ncdc
Copy link
Member Author

ncdc commented Aug 3, 2022

/test all

ncdc added 2 commits August 3, 2022 15:17
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc ncdc force-pushed the clustername-annotation branch from 1fca3ee to 3211444 Compare August 3, 2022 19:18
@ncdc ncdc marked this pull request as ready for review August 3, 2022 19:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2022
@openshift-ci openshift-ci bot requested review from jmprusi and p0lyn0mial August 3, 2022 19:18
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2022
@ncdc
Copy link
Member Author

ncdc commented Aug 3, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@ncdc
Copy link
Member Author

ncdc commented Aug 3, 2022

Assuming the tests are looking good, I'll close #1674 to unblock the merge queue

@sttts
Copy link
Member

sttts commented Aug 3, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2022

@ncdc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-multiple-runs 3211444 link true /test e2e-multiple-runs

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts sttts merged commit 10c6435 into kcp-dev:main Aug 3, 2022
@ncdc ncdc deleted the clustername-annotation branch August 4, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants