Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part 10: scope cross_logical_cluster tests #1667

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Part 10: scope cross_logical_cluster tests #1667

merged 2 commits into from
Aug 5, 2022

Conversation

varshaprasad96
Copy link
Contributor

@varshaprasad96 varshaprasad96 commented Aug 2, 2022 •
edited
Loading

To verify if e2e tests pass in CI

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@varshaprasad96
Copy link
Contributor Author

/test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2022
@varshaprasad96 varshaprasad96 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2022
@varshaprasad96 varshaprasad96 changed the title scope cross_logical_cluster tests Part 10: scope cross_logical_cluster tests Aug 3, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2022
@varshaprasad96 varshaprasad96 marked this pull request as ready for review August 3, 2022 04:44
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2022
@varshaprasad96 varshaprasad96 mentioned this pull request Aug 3, 2022
Closed
46 tasks
sttts
sttts reviewed Aug 4, 2022
View reviewed changes
test/e2e/watchcache/watchcache_enabled_test.go
@@ -68,7 +68,7 @@ func TestWatchCacheEnabledForCRD(t *testing.T) {
crdClient := apiExtensionsClients.Cluster(cluster).ApiextensionsV1().CustomResourceDefinitions()

t.Log("Creating wildwest.dev.cowboys CR")
wildwest.Create(t, crdClient, cowBoysGR)
wildwest.Create(t, logicalcluster.Name{}, crdClient, cowBoysGR)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster, not empty.

Copy link
Contributor Author

@varshaprasad96 varshaprasad96 Aug 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary. I'll create a follow up PR to modify clients in watchcache/ and that will make sure to pass the right cluster name while creating the object. Doing it here, will transitively involve changes in other files, so splitting it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@sttts
Copy link
Member

sttts commented Aug 5, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@openshift-ci openshift-ci bot merged commit c99ede2 into kcp-dev:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varshaprasad96 @sttts @openshift-merge-robot