Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap the root workspace only on the root shard #1587

Conversation

p0lyn0mial
Copy link
Contributor

Summary

the root workspace is only available on the root shard, this pr makes sure it will be only created on it.

Related issue(s)

Fixes #

@p0lyn0mial p0lyn0mial requested a review from sttts July 21, 2022 10:50
@openshift-ci openshift-ci bot requested a review from davidfestal July 21, 2022 10:50
pkg/server/server.go Outdated Show resolved Hide resolved
@p0lyn0mial p0lyn0mial force-pushed the bootstrap-root-ws-only-on-root-shard branch from 2d6d1a4 to 2db9e59 Compare July 21, 2022 12:13
@sttts
Copy link
Member

sttts commented Jul 21, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2022
@p0lyn0mial
Copy link
Contributor Author

/retest

@p0lyn0mial
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 26d9b23 into kcp-dev:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants