Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 3: Make APIResource controller client calls scoped #1558

Merged

Conversation

varshaprasad96
Copy link
Contributor

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from davidfestal and sttts July 18, 2022 22:28
@@ -83,13 +84,14 @@ func main() {
fmt.Fprintln(os.Stderr, err)
os.Exit(1)
}
clusterConfig := kcpclienthelper.NewClusterConfig(config)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a separate clusterConfig here since we need the unmodified config for informers/listers. This will be removed after informers are scoped. /~https://github.com/kcp-dev/kcp/compare/main...varshaprasad96:kcp:wrap-apiresource-controller?expand=1#diff-03df9c971de272e090fac0bbcdb3f0bca9fbccc2f168aafff1e3cdf7e33eb915R100

@varshaprasad96 varshaprasad96 force-pushed the wrap-apiresource-controller branch from fb5afe9 to ff0d1d7 Compare July 18, 2022 22:42
@sttts
Copy link
Member

sttts commented Jul 19, 2022

/retest
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@openshift-ci openshift-ci bot merged commit 1976653 into kcp-dev:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants