server: add --shard-external-url #1542
Conversation
kcp deployers optionally need to be able to set the URL external clients use when connecting to kcp (e.g., via a front proxy). Add a new --shard-external-url flag that is used as the default value for ClusterWorkspaceShard.Spec.ExternalURL. Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
openshift-ci
bot
requested review from
davidfestal,
stevekuznetsov,
csams and
sttts
openshift-ci
bot
added
the
approved
|
/lgtm |
|
@sttts: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csams, ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@sttts: new pull request created: #1547 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
kcp deployers optionally need to be able to set the URL external clients
use when connecting to kcp (e.g., via a front proxy). Add a new
--shard-external-url flag that is used as the default value for
ClusterWorkspaceShard.Spec.ExternalURL.
Related issue(s)
Fixes #