authorization: clarify/fix service accounts and workspace initialization #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test all |
|
|
||
| By default, workspaces are only accessible to a user if they are in phse `Ready`. Workspaces that are initializing | ||
| can be access only by users that are granted `initialize` verb on the `clusterworkspaces/content` resource in the | ||
| parent workspace. |
There was a problem hiding this comment.
I don't think this is necessarily what we want ...
- some RBAC (where???) gives you global access to the initializingworkspaces virtual workspace, where you can see all workspaces that need your initializer
- as a first pass, actions through that workspace impersonate the user who created the workspace
There was a problem hiding this comment.
as discussed OOB: handling service accounts from parent workspaces won't be handled in this PR.
|
|
||
| Kubernetes service accounts is granted access to the workspaces they are defined in and that are ready. | ||
|
|
||
| E.g. a service account "default" in `root:org:ws:ws` is granted access to `root:org:ws:ws`, and through the |
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
s-urbaniak
force-pushed
the
pr-996
branch
2 times, most recently
from
b0b3c5c to
9d88afb
Compare
s-urbaniak
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
s-urbaniak
force-pushed
the
pr-996
branch
3 times, most recently
from
80d7f75 to
518d7e1
Compare
sttts
reviewed
Jun 17, 2022
| ### Initializing Workspaces | ||
|
|
||
| By default, workspaces are only accessible to a user if they are in `Ready` phase. Workspaces that are initializing | ||
| can be access only by users that are granted `admin` verb on the `clusterworkspaces/content` resource in the |
There was a problem hiding this comment.
Suggested change
| can be access only by users that are granted `admin` verb on the `clusterworkspaces/content` resource in the | |
| can be accessed only by users that are granted `admin` verb on the `clusterworkspaces/content` resource in the |
sttts
reviewed
Jun 17, 2022
| cluster, err := genericapirequest.ValidClusterFrom(ctx) | ||
| if err != nil { | ||
| return authorizer.DecisionNoOpinion, fmt.Sprintf("%q workspace access not permitted", cluster.Name), err | ||
| } | ||
| if cluster == nil || cluster.Name.Empty() { | ||
| // empty or non-root based workspaces have no meaning in the context of authorizing workspace content. | ||
| if cluster == nil || cluster.Name.Empty() || !cluster.Name.HasPrefix(tenancyv1alpha1.RootCluster) { | ||
| return authorizer.DecisionNoOpinion, fmt.Sprintf("%q workspace access not permitted", cluster.Name), nil |
There was a problem hiding this comment.
follow-up: workspaceAccessNotPermittedReason everywhere.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
follow-up for #996