Remove support for embedded etcd in Chart #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kcp-ci-bot
added
dco-signoff: yes
|
/lgtm |
|
LGTM label has been added. Git tree hash: cf66c485ba9f6c9050ef04945399bbabb4850cf1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for running with embedded etcd (a mode implemented in kcp for local development) has been added in #51. Unfortunately, it has been broken since #81 when I started eliminating the use of kcp's root directory for anything. A follow-up to that is currently in review at kcp-dev/kcp#3158.
As per the thread on Slack, it seems we are in agreement that this shouldn't be supported anymore. It seems that no adopter is actually using it (since it's broken since beginning of the year) and it creates severe headache to running kcp as a Deployment.