Make etcd service more Istio-friendly #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
dco-signoff: yes
xrstf
reviewed
Oct 7, 2024
|
/hold |
kcp-ci-bot
added
the
do-not-merge/hold
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
|
/hold cancel |
kcp-ci-bot
removed
the
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 4ca437322826e2f9d40a018f98c9db7a23130c61
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to set up kcp in a namespace that has istio injection enabled. Unfortunately, it wasn't working (mainly kcp couldn't talk to etcd over the istio-proxy connection) and threw some obscure error messages suggesting authentication failed.
The problem was actually that Istio couldn't detect the right protocol to proxy. I'm adding the
appProtocolfield to both service ports to ensure that Istio knows it has to proxy HTTPS. In addition, the (client) certificates needed to have127.0.0.6(the istio-proxy sidecar IP) injected so they'd be accepted by the servers. This PR therefore also adds the option to add more ip addresses to the generated certificates.