Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code block wrapping whole document (#36) #49

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Fix code block wrapping whole document (#36) #49

merged 2 commits into from
Jun 26, 2019

Conversation

insaindesign
Copy link
Contributor

@insaindesign insaindesign commented Jun 25, 2019 •
edited by kadikraman
Loading

Code block markdown syntax (```) was wrapping the whole document instead of the specific block when being converted to markdown.

  • Move return string to inside blocks method
  • Add test for this case

Fixes #36

@insaindesign insaindesign changed the title Fix code block wrapping whole document (#25) Fix code block wrapping whole document (#36) Jun 25, 2019
@insaindesign insaindesign mentioned this pull request Jun 25, 2019
Closed
kadikraman
kadikraman approved these changes Jun 26, 2019
View reviewed changes
Copy link
Owner

@kadikraman kadikraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR 🙌

@kadikraman kadikraman merged commit 6da0ed8 into kadikraman:master Jun 26, 2019
@kadikraman
Copy link
Owner

Released in v1.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadikraman kadikraman kadikraman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with code block
2 participants
@insaindesign @kadikraman