Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakup trivy scan and check comment author #10935

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Sep 24, 2024

Proposed Changes

  • Before pull the PR, check that a member of the k3s-dev team requested the /trivy scan.
  • Breakup the workflow to limit permission scope

Types of Changes

CI

Verification

Testing

Linked Issues

#10759

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner September 24, 2024 17:10
brandond
brandond previously approved these changes Sep 24, 2024
cwayne18
cwayne18 previously approved these changes Sep 24, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola dismissed stale reviews from cwayne18 and brandond via fe04bc7 September 24, 2024 17:43
@dereknola dereknola changed the title Check comment author on trivy scan Breakup trivy scan and check comment author Sep 24, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola merged commit 005711f into k3s-io:master Sep 24, 2024
2 checks passed
@dereknola dereknola deleted the tricy_res branch September 24, 2024 20:09
ludost pushed a commit to asimovo-platform/k3s that referenced this pull request Oct 2, 2024
* Check comment author on trivy scan
* Breakup trivy workflow for better permission security

Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants