Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the method of holding the list type step in store from slice to map. #1120

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Dec 18, 2024

This will allow for easier handling of defer.

ref: #1119

…o map.

This will allow for easier handling of defer.

ref: #1119
@k1LoW k1LoW self-assigned this Dec 18, 2024

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW marked this pull request as ready for review December 18, 2024 21:26
@k1LoW k1LoW added the minor label Dec 18, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #1120 (4b774bb) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,550,845,770 ns/op 3,799,487,722 ns/op 248,641,952 ns/op
Bytes allocated per iteration 1,379,938,304 B/op 1,382,039,832 B/op 2,101,528 B/op
Allocs per iteration 18,944,951 allocs/op 18,998,481 allocs/op 53,530 allocs/op
Metadata
main (-) #1120 (4b774bb)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1120 (4b774bb) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,752,055,538 ns/op 4,768,394,165 ns/op 16,338,627 ns/op
Bytes allocated per iteration 2,289,926,184 B/op 2,290,061,440 B/op 135,256 B/op
Allocs per iteration 31,556,628 allocs/op 31,559,143 allocs/op 2,515 allocs/op
Metadata
main (-) #1120 (4b774bb)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1120 (4b774bb) +/-
Number of iterations 24 22 -2
Nanoseconds per iteration 44,393,353 ns/op 45,798,053 ns/op 1,404,700 ns/op
Bytes allocated per iteration 22,907,189 B/op 23,151,376 B/op 244,187 B/op
Allocs per iteration 182,461 allocs/op 183,416 allocs/op 955 allocs/op
Metadata
main (-) #1120 (4b774bb)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (ea242a3) #1120 (4b774bb) +/-
Coverage 64.4% 64.5% +0.0%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 5m44s 5m53s +9s
Details
  |                     | main (ea242a3) | #1120 (4b774bb) |  +/-  |
  |---------------------|----------------|-----------------|-------|
+ | Coverage            |          64.4% |           64.5% | +0.0% |
  |   Files             |             77 |              77 |     0 |
  |   Lines             |           8933 |            8958 |   +25 |
+ |   Covered           |           5759 |            5782 |   +23 |
+ | Code to Test Ratio  |          1:0.7 |           1:0.7 |  +0.0 |
  |   Code              |          16365 |           16403 |   +38 |
+ |   Test              |          12295 |           12498 |  +203 |
- | Test Execution Time |          5m44s |           5m53s |   +9s |

Code coverage of files in pull request scope (77.9% → 78.0%)

Files Coverage +/-
bind.go 81.9% 0.0%
cdp.go 76.8% 0.0%
db.go 76.2% 0.0%
dump.go 69.6% 0.0%
exec.go 73.1% 0.0%
grpc.go 77.4% 0.0%
http.go 78.0% 0.0%
include.go 90.4% 0.0%
operator.go 80.2% -0.1%
runner_runner.go 63.6% 0.0%
ssh.go 66.1% 0.0%
store.go 78.1% +2.0%
test.go 92.5% 0.0%

Reported by octocov

@k1LoW k1LoW merged commit e1b024f into main Dec 18, 2024
9 checks passed
@k1LoW k1LoW deleted the stepList branch December 18, 2024 21:37
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant