Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow user specify project type when adding project #54

Merged
merged 4 commits into from
Oct 29, 2024
Merged

feat: allow user specify project type when adding project #54

merged 4 commits into from
Oct 29, 2024

Conversation

SettingDust
Copy link
Contributor

close #50

@SettingDust SettingDust force-pushed the feature/typed-add branch 2 times, most recently from d1b630b to 6d7dbac Compare October 20, 2024 06:23
juraj-hrivnak
juraj-hrivnak requested changes Oct 29, 2024
View reviewed changes
Copy link
Owner

@juraj-hrivnak juraj-hrivnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

In my opinion, all projectInfos should be renamed to projectIdsToTypes for clarity.

src/commonMain/kotlin/teksturepako/pakku/api/platforms/Modrinth.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/platforms/Modrinth.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/platforms/Modrinth.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/platforms/Provider.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/teksturepako/pakku/cli/cmd/Add.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/teksturepako/pakku/cli/cmd/AddPrj.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/models/mr/MrModpackModel.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/models/mr/MrModpackModel.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/platforms/GitHub.kt Outdated Show resolved Hide resolved
@juraj-hrivnak
Copy link
Owner

Thanks!

@juraj-hrivnak juraj-hrivnak merged commit b1bd3b8 into juraj-hrivnak:main Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juraj-hrivnak juraj-hrivnak juraj-hrivnak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pakku project
Status: Done🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too complex to add data packs
2 participants
@SettingDust @juraj-hrivnak