Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AZURE_OPENAI_API_KEY for Azure OpenAI provider #691

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Use AZURE_OPENAI_API_KEY for Azure OpenAI provider #691

merged 1 commit into from
Mar 26, 2024

Conversation

aroffe99
Copy link
Contributor

Addresses #690 - changes variable in azure auth to comply with openai>1.0

@welcome Welcome
Copy link

welcome bot commented Mar 15, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@srdas srdas added the enhancement New feature or request label Mar 15, 2024
@dlqqq dlqqq changed the title Update providers.py Use AZURE_OPENAI_API_KEY for Azure OpenAI provider Mar 26, 2024
@dlqqq dlqqq force-pushed the update-azure-auth branch from 6e4af99 to 0b674db Compare March 26, 2024 21:18
dlqqq
dlqqq approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you! This will be included in a release shortly to fix issues with the Anthropic and OpenAI providers.

@dlqqq dlqqq merged commit 4722dc7 into jupyterlab:main Mar 26, 2024
8 checks passed
@welcome Welcome
Copy link

welcome bot commented Mar 26, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@dlqqq
Copy link
Member

dlqqq commented Mar 26, 2024

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter-ai that referenced this pull request Mar 26, 2024
@aroffe99 @meeseeksmachine
Backport PR jupyterlab#691: Use AZURE_OPENAI_API_KEY for Azure Open…
e079761 
…AI provider
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 26, 2024
Merged
dlqqq pushed a commit that referenced this pull request Mar 26, 2024
@meeseeksmachine @aroffe99
Backport PR #691: Use AZURE_OPENAI_API_KEY for Azure OpenAI provider (
c2ba62a 
#699)

Co-authored-by: Ari Roffe <aroffe9@gmail.com>
This was referenced Mar 26, 2024
Closed
Closed
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
@aroffe99 @Marchlak
Update providers.py (jupyterlab#691)
80f692c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aroffe99 @dlqqq @srdas