Make links from Jupyter AI chat open in new tab (vs in the same tab currently) #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
LGTM! I think @JasonWeill can help test, as we will do so prior to release later this afternoon.
|
Let's plan on putting this into our December release, as I think it should go out with any other issues identified later this month. |
andrii-i
force-pushed
the
open_help_links_in_new_tab
branch
from
5aaa6c6 to
fefed50
Compare
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Nov 17, 2023
…ew tab (vs in the same tab currently)
andrii-i
added a commit
that referenced
this pull request
Nov 17, 2023
… in the same tab currently) (#476) Co-authored-by: Andrii Ieroshenko <aieroshe@amazon.com>
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Links in Jupyter AI chat are opening in the current window effectively closing the JupyterLab application when clicked. This is confusing and not optimal UX as people usually don't want to close the JupyterLab when clicking a help/documentation link.
Proposed solution
Open links from Jupyter Ai chat in new tab.
This PR introduces a
NewTabLinksubcomponent to open links in new tabs. This component applies target="_blank" for opening in new tabs and rel="noopener noreferrer" for security and privacy.Before:
After:
