Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates package to use tools from newer cookiecutter #44

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

JasonWeill
Copy link
Contributor

Updates files in this package to use the newer cookiecutter per @fcollonval in #43. Now, with jupyter-packaging installed, the jupyter labextension develop . --overwrite completes without errors. (If you don't have that package installed, the script will prompt you to install it.)

@fcollonval
Copy link
Member

fcollonval commented Jan 28, 2022

Thanks a lot @jweill-aws

If you don't have that package installed, the script will prompt you to install it.

Actually if you don't have jupyter-packaging, it does not matter when running jupyter labextension develop . --overwrite. The trouble comes from the need to get the python package name when executing jupyter labextension develop. Hence the new setup.py allows to get it without the need for jupyter-packaging. But the latter is still used by pip in the virtual build environment.

@fcollonval fcollonval merged commit 04db77d into jupyterlab-contrib:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants