Respect the raise_config_file_errors trait and re-raise if applicable. #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was taking a look at jupyterlab/jupyterlab#5716, and found that setting the base
Application
traitraise_config_file_errors
wasn't behaving as I expected. This is becauseJupyterApp
overloads theload_config_file
function and doesn't check this option.A quick audit of the Jupyter ecosystem shows that there are a couple of different behaviors around this.
jupyterhub
inherits fromApplication
rather thanJupyterApp
, so the trait works as expected.IPython
overridesload_config_file
, and specifically checks for this option.JupyterApp
, and they do not respect this option.Another option would be to override the
load_config_file
option in lab/notebook, but it seemed cleaner to me to add this check here.