Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #499
Overview
As we add test for MySQL 8 in #484,
we need to create an additional class to test everything against MySQL 8.
So instead of creating a class based on the database, we'd like to change the test structure,
so that we only need to parameterize which database we want to test against and the entire list of tests will be triggered.
Changes
pymysqlreplication/tests/config.json
.pymysqlreplication/tests/conftest.py
and use
--db
parameter when running pytest.--db
parameter, we set upPyMySQLReplicationTestCase
based on the entered target database to be tested.
:
PyMySQLReplicationMariaDbTestCase
,PyMySQLReplicationVersion8TestCase
Result
Collaborated with @mjs1995 @mikaniz @starcat37