In the arch input, allow ARM64 as a synonym for aarch64
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
force-pushed
the
dpa/arm64-synonym-for-aarch64
branch
from
cb55652 to
cbb0715
Compare
bors bot
added a commit
to JuliaRegistries/CompatHelper.jl
that referenced
this pull request
Jun 20, 2022
430: GitHub Actions: for now, comment out the `${{ runner.arch }}` line r=DilumAluthge a=DilumAluthge
We need julia-actions/setup-julia#108 and julia-actions/setup-julia#110 before we can uncomment this line.
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
|
I like the addition, I'll merge it when CI is fixed. |
DilumAluthge
force-pushed
the
dpa/arm64-synonym-for-aarch64
branch
from
cbb0715 to
7050dbf
Compare
|
@SaschaMann Is this one good to go now? |
SaschaMann
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Yes, it is. Could you also open a PR that documents this option and #108, please?
Then I'll tag a release.
bors bot
added a commit
to JuliaRegistries/CompatHelper.jl
that referenced
this pull request
Aug 15, 2022
434: GitHub Actions: uncomment the `${{ runner.arch }}` line r=DilumAluthge a=DilumAluthge
Follow-up to #430.
julia-actions/setup-julia#108 and julia-actions/setup-julia#110 have been merged and are available in a release, so we can now uncomment this line.
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
bors bot
added a commit
to JuliaRegistries/CompatHelper.jl
that referenced
this pull request
Aug 15, 2022
434: GitHub Actions: uncomment the `${{ runner.arch }}` line r=DilumAluthge a=DilumAluthge
Follow-up to #430.
julia-actions/setup-julia#108 and julia-actions/setup-julia#110 have been merged and are available in a release, so we can now uncomment this line.
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for compatibility with the
${{ runner.arch }}variable, which takes on the following values:X86,X64,ARM, orARM64.Fixes #107