-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing meta to jsx-tag-spacing #1650
Merged
ljharb
merged 1 commit into
jsx-eslint:master
from
xinminlabs:add-missing-meta-to-jsx-tag-spacing
Jan 20, 2018
Merged
add missing meta to jsx-tag-spacing #1650
ljharb
merged 1 commit into
jsx-eslint:master
from
xinminlabs:add-missing-meta-to-jsx-tag-spacing
Jan 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jan 20, 2018
lib/rules/jsx-tag-spacing.js
Outdated
@@ -221,7 +221,11 @@ function validateBeforeClosing(context, node, option) { | |||
|
|||
module.exports = { | |||
meta: { | |||
deprecated: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this marked deprecated?
flyerhzm
force-pushed
the
add-missing-meta-to-jsx-tag-spacing
branch
from
January 20, 2018 06:52
56d3e51
to
d3840a5
Compare
@ljharb sorry, I read the wrong doc. It's updated now. |
ljharb
approved these changes
Jan 20, 2018
This was referenced Jan 26, 2018
This was referenced Feb 2, 2018
Closed
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just add some missing meta