-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/same submission #829
Fix/same submission #829
Conversation
cyfml
commented
Dec 4, 2022
•
edited
Loading
edited
- fixed same submission problem which leads Comparision-Viewer broken.
- fixed issue: The folder in the results holding the submission files should be renamed from "submissions" to "files", and report-viewer also supports old version of Jplag. (e.g. submissions in zip file).
- Enhancement:
- where the files are dropped should contain a line of text that states that no files get uploaded anywhere
- The code comparison view always shows "submission 1" and "submission 2", but should show the names. But not if the names are hidden.
- In the code comparison view, the left sidebar should be visible by default
9f8c7e8
to
58272be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ion-and-root-name
…ion-and-root-name
Now, report-viewer supports old version of Jplag. I also find a bug in the previous PR. This bug is: if root name or sub directory is also called "submissions". The Comparison view will not be broken but show not full path, then it influences the highlighting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review for the Java changes, I found just one small thing.
core/src/main/java/de/jplag/reporting/jsonfactory/DirectoryManager.java
Outdated
Show resolved
Hide resolved
Besides this change, I have nothing to complain. I'm not happy with the complexity of the |
@sebinside Yes. The complexity of the |
Kudos, SonarCloud Quality Gate passed! |
@tsaglam @sebinside I suggest, it's better to change the name of PR to "Fix/same submission". Same root problem was postponed. |