-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/match display off-by-one error and reenable clustering display #816
Fix/match display off-by-one error and reenable clustering display #816
Conversation
…y-and-reenable-Cluster
Just a reminder from the discussion: Please also fix that the starting line is off by one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains new test resources but no new test case? They are probably from testing and can be removed, right?
Yes. After today's classes, i will take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks okay to me, the match display also seems to work correctly now.
However, we noticed a bug in the ReportGenerator (not your fault, this bug probably existed for a long time). Sometimes, the submission IDs in the array of the cluster's members are serialized as null
which breaks everything. I will try to have a look at it next week. If would be good if you could also try to replicate this behavior. Currently, I don't know why this happens.
Example:
{"average_similarity":0.31,"strength":3.72396E-5,"members":["SubmissionA","SubmissionB",null,null,null,null]}
core/src/main/java/de/jplag/reporting/reportobject/ReportObjectFactory.java
Outdated
Show resolved
Hide resolved
We found another bug in the report generation, it was fixed with #842. Please rebase your PR so that we can test it again, afterward, it can be merged. |
…y-and-reenable-Cluster
@sebinside already done. |
Kudos, SonarCloud Quality Gate passed! |
I fixed the bug: The ends of displayed matches are sometimes off by one and re-enable cluster. It is based on that file path problem is resolved (last PR).
In addition, i added a test case to test cluster.