FilePathUtils.joinZipPathSegments error on windows

[TwoOfTwelve]

The file creation now uses the path api instead of manual concatenation. I cannot test it on windows. So it would be great if someone could confirm it also works on windows.

Fixes #1592

[Kr0nox]

This does not generate the expected report with the single submission files, so just a folder with files.
Input folder:

Folder
└Sub1.java
└Sub2.java

We would expect the report zip be look like this:

files
 └Sub1.java (This is a folder)
 |  └ Sub1.java
 └Sub2.java (This is a folder)
 |  └ Sub2.java
Json Files

But the zip looks like this:

files
 └Sub1.java (This is a file)
 └Sub2.java (This is a file)
Json Files

[TwoOfTwelve]

I think this is again an issue with submissions without sub-directories. I will look into it tomorrow.

[Kr0nox]

Also fixes #1610

I would suggest moving this to a diferent PR, since it is very independent of the other issue

We should also disguss how we want the file names to actually look like

[TwoOfTwelve]

I agree, but since the solutions depend on one another I would only create the second PR after this one has been merged.

[Kr0nox]

Except for some JDoc this looks good.

Tested on windows

[tsaglam]

Just three minor things to discuss.

[tsaglam]

Is the explicit backslash intentional? Is it another concept or why is the constant with the same value not used?

[TwoOfTwelve]

The slash here is intentional, as we simply need a path that represents a root. It does not matter which, but in my opinion a UNIX root is the simplest. It does not use the constant, because the divider for zip paths is something else than a root. If you prefer it, I can change it to use the constant or a new one instead.

[Kr0nox]

Tested on windows. Works with:

• Single Submission Folder
• Multiple Submission Folders
• Single Folder of Submission Foles
• Multiple Folders of submission files (appart from [bug] File structure discrepancy  #1610

[sonarqubecloud]

Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud