Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves the help output for the cli. #1220

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Improves the help output for the cli. #1220

merged 4 commits into from
Aug 10, 2023

Conversation

TwoOfTwelve
Copy link
Contributor

@TwoOfTwelve TwoOfTwelve commented Aug 4, 2023 •
edited
Loading

Some minor improvements for the help output of the cli:

  1. The description part is now shown at the top
  2. For enum options the list of available values is now shown.

@tsaglam
Copy link
Member

tsaglam commented Aug 4, 2023

Can you extend the PR description to be more specific?

@TwoOfTwelve TwoOfTwelve requested review from tsaglam and Kr0nox August 5, 2023 15:47
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Aug 7, 2023
tsaglam
tsaglam approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

cli/src/main/java/de/jplag/cli/CLI.java Outdated Show resolved Hide resolved
cli/src/main/java/de/jplag/cli/CLI.java Outdated Show resolved Hide resolved
cli/src/main/java/de/jplag/cli/ParamLabelRenderer.java Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.2% 95.2% Coverage
0.0% 0.0% Duplication

@tsaglam tsaglam merged commit e992e87 into develop Aug 10, 2023
@dfuchss dfuchss deleted the feature/cli-small-improvements branch December 6, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

@Kr0nox Kr0nox Awaiting requested review from Kr0nox

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwoOfTwelve @tsaglam