This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
don't allocate string when writing to csv #935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing to csv is pretty slow. Polars can read two datetime columns in 500 ms, whereas writing the same data to csv takes 33.6 seconds.
Upon looking at the code I saw we allocate a
String
for every value weformat
.This PR makes sure we write immediately to the
Vec<u8>
buffer.