Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Allowed passing None as ipc_fields in flight API #780

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

jorgecarleitao
Copy link
Owner

This was a regression vs 0.8 - users should be allowed to pass Option to retain the previous behavior.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #780 (1397210) into main (9f25174) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   71.07%   71.06%   -0.01%     
==========================================
  Files         316      316              
  Lines       16755    16760       +5     
==========================================
+ Hits        11908    11911       +3     
- Misses       4847     4849       +2     
Impacted Files Coverage Δ
src/io/flight/mod.rs 0.00% <0.00%> (ø)
src/compute/arithmetics/time.rs 26.60% <0.00%> (+0.91%) ⬆️
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️
src/io/avro/read/schema.rs 55.91% <0.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f25174...1397210. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Allowed None IPC field Allowed None IPC field in flight Jan 19, 2022
@jorgecarleitao jorgecarleitao changed the title Allowed None IPC field in flight Allowed passing None as ipc_fields in flight API Jan 19, 2022
@jorgecarleitao jorgecarleitao merged commit 39f730a into main Jan 19, 2022
@jorgecarleitao jorgecarleitao deleted the fix_flight1 branch January 19, 2022 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant