Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Removed unneeded trait. #628

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Removed unneeded trait. #628

merged 1 commit into from
Nov 24, 2021

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Nov 23, 2021

Removes a trait that was only used once and did not offer sufficient benefits to justify its existence.

This is backward incompatible since the trait no longer exists. No migration path: the struct that implemented it already had the same method.

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #628 (e55b450) into main (439dacf) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   69.78%   69.81%   +0.02%     
==========================================
  Files         299      299              
  Lines       16667    16663       -4     
==========================================
+ Hits        11631    11633       +2     
+ Misses       5036     5030       -6     
Impacted Files Coverage Δ
src/io/ipc/read/reader.rs 72.99% <ø> (+1.05%) ⬆️
src/record_batch.rs 51.42% <ø> (+1.42%) ⬆️
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️
src/compute/arithmetics/time.rs 46.93% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 439dacf...e55b450. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 9ba5228 into main Nov 24, 2021
@jorgecarleitao jorgecarleitao deleted the rm branch November 24, 2021 07:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant